Tech Note: Stinky’s Refactoring Binge

Charles Johnsonfollow me on twitter
Science • Sat Sep 27, 2008 at 5:34 pm PDT • Views: 258

Stinky Beaumont is project-managing a major code refactoring process this weekend, that we’ve been putting off because it’s painful. We’re talking duplicated code. Global variables. Inconsistent variable naming. Remnants from the days before we started coding smart, instead of just getting it working. It’s not all like this, but the Ajax-based comments code in particular still had a funny smell in some neglected corners. In other words, it worked but it wasn’t sleek.

We’re replacing duplicated code with object methods, or functions where the procedural code still needs more untangling. Replacing global variables with constants where possible, object properties where not.

It’s happening bit by bit, piece by piece, step by step. While loop by function call. Much of the ‘new comments’ logic has now been refactored in this way, and the front page and daily archives pages now use a common display interface.

And with that, I’m opening registration for a very limited time.

UPDATE at 9/27/08 5:45:20 pm:

Here’s a tip that comes in handy for eliminating global variables in PHP.

Constants are very useful for this purpose. They’re automatically available in the global scope. But they’re limited to numbers or strings. No arrays. Bummer.

But you can define an array, then serialize it and define the resulting serialized string as a constant. Then when you need to use it, even within a function or object method, you can simply unserialize the array and you’re good to go. For example, to define the serialized array:

$myItems = array('item1', 'item2', 'item3');
define('MY_ITEMS', serialize($myItems));

Then, to access the “array constant:”

$array = unserialize(MY_ITEMS);

UPDATE at 9/28/08 9:54:46 am:

LGF reader “scrad” pointed out that you can access any variable in the global scope (including arrays and objects) by using PHP's $GLOBALS array. The above example could also be coded this way (eliminating the overhead of the serialize/unserialize functions):

$myItems = array('item1', 'item2', 'item3');

To access the second item in the array:

$item2 = $GLOBALS['myItems'][1];

Advertisement

709 comments

^ back to top ^

Name:

Pass:

Register Forgot Your Password? Account Settings Re-send Confirmation (To log in, cookies must be enabled in your browser!)

Turn off ads by subscribing!
For about 33 cents a day, our subscription option turns off all advertisements at LGF!
Read more...


► LGF Headlines

  • Loading...

► Tweeted Articles

  • Loading...

► Tweeted Pages

  • Loading...

► Top 10 Comments

  • Loading...

► Bottom Comments

  • Loading...

► Recent Comments

  • Loading...

► Tools/Info

► LGF Hits

► Resources

► Never Forget

► Statistics

► Tag Cloud

► Contact

You must have Javascript enabled to use the contact form.
Your email:

Subject:

Message:


Messages may be published in our weblog, unless you request otherwise.
Tech Note:
Using the Contact Form

More Partners

Compare Electricity Prices in your area. Texas Electricity is deregulated; you have the right to choose Texas Electric Rates from among many Texas Electric Companies.

The fuad ramses of web design.

TwitterFacebook
LGF Pages
Recent Pages

Bob Dillon
Chemist Applies Google Software to Molecules
3 minutes ago
Views: 3 • Comments: 0
Tweets: 0 • Rating: 0

Daniel Ballard
Meme: What Photographers Actually Do
18 minutes ago
Views: 24 • Comments: 0
Tweets: 0 • Rating: 0

Aigle
Judi Rudoren Enters the Scene: Tweets or Tea Leaves?
36 minutes ago
Views: 19 • Comments: 0
Tweets: 0 • Rating: 0

Aigle
New Online Newspaper in Israel
37 minutes ago
Views: 24 • Comments: 0
Tweets: 0 • Rating: 0

Daniel Ballard
The Boy Who Played With Fusion
1 hour, 25 minutes ago
Views: 77 • Comments: 0
Tweets: 0 • Rating: 2

wrenchwench
Mexico Issues Travel Warning for Los United Estates
1 hour, 33 minutes ago
Views: 76 • Comments: 0
Tweets: 1 • Rating: 1

Channeling Confucius
6 Terrifying User Agreements You've Probably Accepted
2 hours, 28 minutes ago
Views: 89 • Comments: 0
Tweets: 0 • Rating: 1

Turnabout is Fair Play
The Muslim Brotherhood's Post-Mubarak Anti-Americanism
2 hours, 42 minutes ago
Views: 78 • Comments: 0
Tweets: 0 • Rating: 1

MichaelJ
Daring Fireball: Walter Isaacson's 'Steve Jobs'
2 hours, 57 minutes ago
Views: 85 • Comments: 0
Tweets: 0 • Rating: 0

Bob Dillon
Radiation Generates Cancer Stem Cells From Less Aggressive Breast Cancer Cells
4 hours, 20 minutes ago
Views: 84 • Comments: 0
Tweets: 0 • Rating: 0

 Frank says:

Children are naive -- they trust everyone. School is bad enough, but, if you put a child anywhere in the vicinity of a church, you're asking for trouble.